PDA

View Full Version : Help trim code down


TheLaughingBandit
09-02-03, 10:50 AM
i wrote this code so that i could have six groups of six radio buttons with six different values and in each group only one radio could be selected (inherent when all the buttons in the group are named the same) and also so that the same button can not be chosen in more than one set.

then i added a function so that the form cannot be submitted with out a button selected in each group.

please note (some people have gotten confused on this part i think) in the below code set1,set2, set3,set4,set5,set6 sets of numbers that make up the each of the values, the sets do not refer to the groups.

any way i am hopeing the is a way to trim this fat lady down.

<script language="javascript">

function VerifyStrSet1() {
if ((document.attributes.dex.set1.checked) ||
(document.attributes.con.set1.checked) ||
(document.attributes.intel.set1.checked) ||
(document.attributes.wis.set1.checked) ||
(document.attributes.cha.set1.checked)) {
alert("Set 1 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyStrSet2() {
if ((document.attributes.dex.set2.checked) ||
(document.attributes.con.set2.checked) ||
(document.attributes.intel.set2.checked) ||
(document.attributes.wis.set2.checked) ||
(document.attributes.cha.set2.checked)) {
alert("Set 2 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyStrSet3() {
if ((document.attributes.dex.set3.checked) ||
(document.attributes.con.set3.checked) ||
(document.attributes.intel.set3.checked) ||
(document.attributes.wis.set3.checked) ||
(document.attributes.cha.set3.checked)) {
alert("Set 3 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyStrSet4() {
if ((document.attributes.dex.set4.checked) ||
(document.attributes.con.set4.checked) ||
(document.attributes.intel.set4.checked) ||
(document.attributes.wis.set4.checked) ||
(document.attributes.cha.set4.checked)) {
alert("Set 4 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyStrSet5() {
if ((document.attributes.dex.set5.checked) ||
(document.attributes.con.set5.checked) ||
(document.attributes.intel.set5.checked) ||
(document.attributes.wis.set5.checked) ||
(document.attributes.cha.set5.checked)) {
alert("Set 5 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyStrSet6() {
if ((document.attributes.dex.set6.checked) ||
(document.attributes.con.set6.checked) ||
(document.attributes.intel.set6.checked) ||
(document.attributes.wis.set6.checked) ||
(document.attributes.cha.set6.checked)) {
alert("Set 6 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyDexSet1() {
if ((document.attributes.str.set1.checked) ||
(document.attributes.con.set1.checked) ||
(document.attributes.intel.set1.checked) ||
(document.attributes.wis.set1.checked) ||
(document.attributes.cha.set1.checked)) {
alert("Set 1 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyDexSet2() {
if ((document.attributes.str.set2.checked) ||
(document.attributes.con.set2.checked) ||
(document.attributes.intel.set2.checked) ||
(document.attributes.wis.set2.checked) ||
(document.attributes.cha.set2.checked)) {
alert("Set 2 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyDexSet3() {
if ((document.attributes.str.set3.checked) ||
(document.attributes.con.set3.checked) ||
(document.attributes.intel.set3.checked) ||
(document.attributes.wis.set3.checked) ||
(document.attributes.cha.set3.checked)) {
alert("Set 3 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyDexSet4() {
if ((document.attributes.str.set4.checked) ||
(document.attributes.con.set4.checked) ||
(document.attributes.intel.set4.checked) ||
(document.attributes.wis.set4.checked) ||
(document.attributes.cha.set4.checked)) {
alert("Set 4 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyDexSet5() {
if ((document.attributes.str.set5.checked) ||
(document.attributes.con.set5.checked) ||
(document.attributes.intel.set5.checked) ||
(document.attributes.wis.set5.checked) ||
(document.attributes.cha.set5.checked)) {
alert("Set 5 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyDexSet6() {
if ((document.attributes.str.set6.checked) ||
(document.attributes.con.set6.checked) ||
(document.attributes.intel.set6.checked) ||
(document.attributes.wis.set6.checked) ||
(document.attributes.cha.set6.checked)) {
alert("Set 6 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyConSet1() {
if ((document.attributes.str.set1.checked) ||
(document.attributes.dex.set1.checked) ||
(document.attributes.intel.set1.checked) ||
(document.attributes.wis.set1.checked) ||
(document.attributes.cha.set1.checked)) {
alert("Set 1 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyConSet2() {
if ((document.attributes.str.set2.checked) ||
(document.attributes.dex.set2.checked) ||
(document.attributes.intel.set2.checked) ||
(document.attributes.wis.set2.checked) ||
(document.attributes.cha.set2.checked)) {
alert("Set 2 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyConSet3() {
if ((document.attributes.str.set3.checked) ||
(document.attributes.dex.set3.checked) ||
(document.attributes.intel.set3.checked) ||
(document.attributes.wis.set3.checked) ||
(document.attributes.cha.set3.checked)) {
alert("Set 3 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyConSet4() {
if ((document.attributes.str.set4.checked) ||
(document.attributes.dex.set4.checked) ||
(document.attributes.intel.set4.checked) ||
(document.attributes.wis.set4.checked) ||
(document.attributes.cha.set4.checked)) {
alert("Set 4 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyConSet5() {
if ((document.attributes.str.set5.checked) ||
(document.attributes.dex.set5.checked) ||
(document.attributes.intel.set5.checked) ||
(document.attributes.wis.set5.checked) ||
(document.attributes.cha.set5.checked)) {
alert("Set 5 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyConSet6() {
if ((document.attributes.str.set6.checked) ||
(document.attributes.dex.set6.checked) ||
(document.attributes.intel.set6.checked) ||
(document.attributes.wis.set6.checked) ||
(document.attributes.cha.set6.checked)) {
alert("Set 6 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyIntelSet1() {
if ((document.attributes.str.set1.checked) ||
(document.attributes.dex.set1.checked) ||
(document.attributes.con.set1.checked) ||
(document.attributes.wis.set1.checked) ||
(document.attributes.cha.set1.checked)) {
alert("Set 1 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyIntelSet2() {
if ((document.attributes.str.set2.checked) ||
(document.attributes.dex.set2.checked) ||
(document.attributes.con.set2.checked) ||
(document.attributes.wis.set2.checked) ||
(document.attributes.cha.set2.checked)) {
alert("Set 2 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyIntelSet3() {
if ((document.attributes.str.set3.checked) ||
(document.attributes.dex.set3.checked) ||
(document.attributes.con.set3.checked) ||
(document.attributes.wis.set3.checked) ||
(document.attributes.cha.set3.checked)) {
alert("Set 3 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyIntelSet4() {
if ((document.attributes.str.set4.checked) ||
(document.attributes.dex.set4.checked) ||
(document.attributes.con.set4.checked) ||
(document.attributes.wis.set4.checked) ||
(document.attributes.cha.set4.checked)) {
alert("Set 4 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyIntelSet5() {
if ((document.attributes.str.set5.checked) ||
(document.attributes.dex.set5.checked) ||
(document.attributes.con.set5.checked) ||
(document.attributes.wis.set5.checked) ||
(document.attributes.cha.set5.checked)) {
alert("Set 5 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyIntelSet6() {
if ((document.attributes.str.set6.checked) ||
(document.attributes.dex.set6.checked) ||
(document.attributes.con.set6.checked) ||
(document.attributes.wis.set6.checked) ||
(document.attributes.cha.set6.checked)) {
alert("Set 6 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyWisSet1() {
if ((document.attributes.str.set1.checked) ||
(document.attributes.dex.set1.checked) ||
(document.attributes.con.set1.checked) ||
(document.attributes.intel.set1.checked) ||
(document.attributes.cha.set1.checked)) {
alert("Set 1 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyWisSet2() {
if ((document.attributes.str.set2.checked) ||
(document.attributes.dex.set2.checked) ||
(document.attributes.con.set2.checked) ||
(document.attributes.intel.set2.checked) ||
(document.attributes.cha.set2.checked)) {
alert("Set 2 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyWisSet3() {
if ((document.attributes.str.set3.checked) ||
(document.attributes.dex.set3.checked) ||
(document.attributes.con.set3.checked) ||
(document.attributes.intel.set3.checked) ||
(document.attributes.cha.set3.checked)) {
alert("Set 3 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyWisSet4() {
if ((document.attributes.str.set4.checked) ||
(document.attributes.dex.set4.checked) ||
(document.attributes.con.set4.checked) ||
(document.attributes.intel.set4.checked) ||
(document.attributes.cha.set4.checked)) {
alert("Set 4 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyWisSet5() {
if ((document.attributes.str.set5.checked) ||
(document.attributes.dex.set5.checked) ||
(document.attributes.con.set5.checked) ||
(document.attributes.intel.set5.checked) ||
(document.attributes.cha.set5.checked)) {
alert("Set 5 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyWisSet6() {
if ((document.attributes.str.set6.checked) ||
(document.attributes.dex.set6.checked) ||
(document.attributes.con.set6.checked) ||
(document.attributes.intel.set6.checked) ||
(document.attributes.cha.set6.checked)) {
alert("Set 6 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyChaSet1() {
if ((document.attributes.str.set1.checked) ||
(document.attributes.dex.set1.checked) ||
(document.attributes.con.set1.checked) ||
(document.attributes.intel.set1.checked) ||
(document.attributes.wis.set1.checked)) {
alert("Set 1 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyChaSet2() {
if ((document.attributes.str.set2.checked) ||
(document.attributes.dex.set2.checked) ||
(document.attributes.con.set2.checked) ||
(document.attributes.intel.set2.checked) ||
(document.attributes.wis.set2.checked)) {
alert("Set 2 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyChaSet3() {
if ((document.attributes.str.set3.checked) ||
(document.attributes.dex.set3.checked) ||
(document.attributes.con.set3.checked) ||
(document.attributes.intel.set3.checked) ||
(document.attributes.wis.set3.checked)) {
alert("Set 3 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyChaSet4() {
if ((document.attributes.str.set4.checked) ||
(document.attributes.dex.set4.checked) ||
(document.attributes.con.set4.checked) ||
(document.attributes.intel.set4.checked) ||
(document.attributes.wis.set4.checked)) {
alert("Set 4 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyChaSet5() {
if ((document.attributes.str.set5.checked) ||
(document.attributes.dex.set5.checked) ||
(document.attributes.con.set5.checked) ||
(document.attributes.intel.set5.checked) ||
(document.attributes.wis.set5.checked)) {
alert("Set 5 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}
function VerifyChaSet6() {
if ((document.attributes.str.set6.checked) ||
(document.attributes.dex.set6.checked) ||
(document.attributes.con.set6.checked) ||
(document.attributes.intel.set6.checked) ||
(document.attributes.wis.set6.checked)) {
alert("Set 6 on has already been chosen for a different attrtibute.");
return false;
} else
return true;
}

function VerifyData() {
if ((!document.attributes.str.set1.checked) &&
(!document.attributes.str.set2.checked) &&
(!document.attributes.str.set3.checked) &&
(!document.attributes.str.set4.checked) &&
(!document.attributes.str.set5.checked) &&
(!document.attributes.str.set6.checked)) {
alert("You must select a Set for Stength.");
return false;
} else if ((!document.attributes.dex.set1.checked) &&
(!document.attributes.dex.set2.checked) &&
(!document.attributes.dex.set3.checked) &&
(!document.attributes.dex.set4.checked) &&
(!document.attributes.dex.set5.checked) &&
(!document.attributes.dex.set6.checked)) {
alert("You must select a Set for Dexterity.");
return false;
} else if ((!document.attributes.con.set1.checked) &&
(!document.attributes.con.set2.checked) &&
(!document.attributes.con.set3.checked) &&
(!document.attributes.con.set4.checked) &&
(!document.attributes.con.set5.checked) &&
(!document.attributes.con.set6.checked)) {
alert("You must select a Set for Constitution.");
return false;
} else if ((!document.attributes.intel.set1.checked) &&
(!document.attributes.intel.set2.checked) &&
(!document.attributes.intel.set3.checked) &&
(!document.attributes.intel.set4.checked) &&
(!document.attributes.intel.set5.checked) &&
(!document.attributes.intel.set6.checked)) {
alert("You must select a Set for Intelligence.");
return false;
} else if ((!document.attributes.wis.set1.checked) &&
(!document.attributes.wis.set2.checked) &&
(!document.attributes.wis.set3.checked) &&
(!document.attributes.wis.set4.checked) &&
(!document.attributes.wis.set5.checked) &&
(!document.attributes.wis.set6.checked)) {
alert("You must select a Set for Wisdom.");
return false;
} else if ((!document.attributes.cha.set1.checked) &&
(!document.attributes.cha.set2.checked) &&
(!document.attributes.cha.set3.checked) &&
(!document.attributes.cha.set4.checked) &&
(!document.attributes.cha.set5.checked) &&
(!document.attributes.cha.set6.checked)) {
alert("You must select a Set for Charisma.");
return false;
} else
return true;
}
</script>

<form method="POST" action="x2.asp" name="attributes" onSubmit="return VerifyData()">
<table width="610" bgcolor="#D7D21E" cellspacing="0" cellpadding="0" border="2" bordercolor="#800000" align="center">
<tr><!-- Row 1 -->
<td>
<table width="100%" cellspacing="0" cellpadding="0" border="0">
<tr><!-- Row 1 -->
<td align="center" bgcolor="#800000">Strength</td>
<td align="center" bgcolor="#800000">Dexterity</td>
</tr>
<tr><!-- Row 2 -->
<td align="center">
<input type="radio" name="str" id="set1" onClick="return VerifyStrSet1()" value="<%=total%>">Set 1
<input type="radio" name="str" id="set2" onClick="return VerifyStrSet2()" value="<%=total2%>">Set 2
<input type="radio" name="str" id="set3" onClick="return VerifyStrSet3()" value="<%=total3%>">Set 3
<input type="radio" name="str" id="set4" onClick="return VerifyStrSet4()" value="<%=total4%>">Set 4
<input type="radio" name="str" id="set5" onClick="return VerifyStrSet5()" value="<%=total5%>">Set 5
<input type="radio" name="str" id="set6" onClick="return VerifyStrSet6()" value="<%=total6%>">Set 6
</td>
<td align="center">
<input type="radio" name="dex" id="set1" onClick="return VerifyDexSet1()" value="<%=total%>">Set 1
<input type="radio" name="dex" id="set2" onClick="return VerifyDexSet2()" value="<%=total2%>">Set 2
<input type="radio" name="dex" id="set3" onClick="return VerifyDexSet3()" value="<%=total3%>">Set 3
<input type="radio" name="dex" id="set4" onClick="return VerifyDexSet4()" value="<%=total4%>">Set 4
<input type="radio" name="dex" id="set5" onClick="return VerifyDexSet5()" value="<%=total5%>">Set 5
<input type="radio" name="dex" id="set6" onClick="return VerifyDexSet6()" value="<%=total6%>">Set 6
</td>
</tr>
<tr><!-- Row 3 -->
<td align="center" bgcolor="#800000">Constitution</td>
<td align="center" bgcolor="#800000">Intelligence</td>
</tr>
<tr><!-- Row 4 -->
<td align="center">
<input type="radio" name="con" id="set1" onClick="return VerifyConSet1()" value="<%=total%>">Set 1
<input type="radio" name="con" id="set2" onClick="return VerifyConSet2()" value="<%=total2%>">Set 2
<input type="radio" name="con" id="set3" onClick="return VerifyConSet3()" value="<%=total3%>">Set 3
<input type="radio" name="con" id="set4" onClick="return VerifyConSet4()" value="<%=total4%>">Set 4
<input type="radio" name="con" id="set5" onClick="return VerifyConSet5()" value="<%=total5%>">Set 5
<input type="radio" name="con" id="set6" onClick="return VerifyConSet6()" value="<%=total6%>">Set 6
</td>
<td align="center">
<input type="radio" name="intel" id="set1" onClick="return VerifyIntelSet1()" value="<%=total%>">Set 1
<input type="radio" name="intel" id="set2" onClick="return VerifyIntelSet2()" value="<%=total2%>">Set 2
<input type="radio" name="intel" id="set3" onClick="return VerifyIntelSet3()" value="<%=total3%>">Set 3
<input type="radio" name="intel" id="set4" onClick="return VerifyIntelSet4()" value="<%=total4%>">Set 4
<input type="radio" name="intel" id="set5" onClick="return VerifyIntelSet5()" value="<%=total5%>">Set 5
<input type="radio" name="intel" id="set6" onClick="return VerifyIntelSet6()" value="<%=total6%>">Set 6
</td>
</tr>
<tr><!-- Row 5 -->
<td align="center" bgcolor="#800000">Wisdom</td>
<td align="center" bgcolor="#800000">Charisma</td>
</tr>
<tr><!-- Row 6 -->
<td align="center">
<input type="radio" name="wis" id="set1" onClick="return VerifyWisSet1()" value="<%=total%>">Set 1
<input type="radio" name="wis" id="set2" onClick="return VerifyWisSet2()" value="<%=total2%>">Set 2
<input type="radio" name="wis" id="set3" onClick="return VerifyWisSet3()" value="<%=total3%>">Set 3
<input type="radio" name="wis" id="set4" onClick="return VerifyWisSet4()" value="<%=total4%>">Set 4
<input type="radio" name="wis" id="set5" onClick="return VerifyWisSet5()" value="<%=total5%>">Set 5
<input type="radio" name="wis" id="set6" onClick="return VerifyWisSet6()" value="<%=total6%>">Set 6
</td>
<td align="center">
<input type="radio" name="cha" id="set1" onClick="return VerifyChaSet1()" value="<%=total%>">Set 1
<input type="radio" name="cha" id="set2" onClick="return VerifyChaSet2()" value="<%=total2%>">Set 2
<input type="radio" name="cha" id="set3" onClick="return VerifyChaSet3()" value="<%=total3%>">Set 3
<input type="radio" name="cha" id="set4" onClick="return VerifyChaSet4()" value="<%=total4%>">Set 4
<input type="radio" name="cha" id="set5" onClick="return VerifyChaSet5()" value="<%=total5%>">Set 5
<input type="radio" name="cha" id="set6" onClick="return VerifyChaSet6()" value="<%=total6%>">Set 6
</td>
</tr>
</table>
</td>
</tr>
</table>
<br>
<div align="right"><input type="submit" name="Submit" value="Next" class="inputSubmit"></div>
</form>